Categories
Programming

Dangling comma’s are gross

I’m not a code style purest. I can swap styles with out much complaint. As long as code is in one unified style I am happy. But there is one thing that just doesn’t sit right with me and that’s the dangling comma.

Look at it there, just hanging off the end of the last line of code. It’s patiently waiting for the day when someone might put it to use. Yes, yes I know that you get a better git history with it sticking there for who knows how long.

To me it’s like a booger just hanging off of someone’s nose. Discreetly hand that code a tissue and tell it to wipe its face. I guess in this analogy you would be the one wiping the code of the thing just dangling there. Whatever the case I find it; unsightly, ugly, annoying,

What, I didn’t finish the list? Maybe I’ll come back to it some day. At least the comma is there waiting for me.

Categories
Debugging

Rsyslog stops logging after logrotate

Are you seeing an empty /var/log/haproxy.traffic.log file after logrotate does it’s business? Perhaps it’s your postrotate script!

Several tutorials on the web call “reload” in the logrotate postrotate script. For example the following is old and busted.

/var/log/haproxy.log {
    ...
    postrotate
        reload rsyslog >/dev/null 2>&1 || true
    endscript
}

On my CentOS systems I removed the error redirect and manually ran logrotate with logrotate -v --force /etc/logratate.d/haproxy. The output revealed that the reload command was no where to be found.

running postrotate script
logrotate_script: line 1: reload: command not found

Instead of reload use kill -HUP as follows. The man pages for rsyslogd state that HUP “lets rsyslogd perform close all open files.” Please do ensure that your pid exists at /run/rsyslogd.pid

/var/log/haproxy.log {
    ...
    postrotate
        /bin/kill -HUP `cat /run/rsyslogd.pid 2> /dev/null` 2> /dev/null || true
    endscript
}

As far as I can tell reload was removed during the switch to systemd in CentOS 7. Although, I had a lot of trouble figuring out exactly what changes caused the initial script to be incorrect.